From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
Matt_Domsch@dell.com, Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH] ata: Add support for Long Logical Sectors and Long Physical Sectors
Date: Mon, 18 Aug 2008 19:06:29 +0100 [thread overview]
Message-ID: <20080818190629.22fd618c@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080818181523.GG677@parisc-linux.org>
> + static const char command_sect_size[256] = {
> + [ ATA_CMD_CFA_TRANSLATE_SECTOR ] = DEVICE,
Should be a bit array so we can do a single fast test_bit()
> + if (size == UNKNOWN && printk_ratelimit())
> + printk("Unknown ata cmd %d, assuming 512 byte sector size\n",
> + command);
or two bits ;)
Rest looks ok. I'll probably send a follow up patch to make most pata
drivers return "no" to anything but 512 until we can test them with real
devices.
Alan
next prev parent reply other threads:[~2008-08-18 18:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 17:26 LibATA support for long sectors Matthew Wilcox
2008-08-05 17:26 ` [PATCH] ata: Define new commands from ATA8 Matthew Wilcox
2008-08-05 20:10 ` Greg Freemyer
2008-08-05 17:26 ` [PATCH] ata: Add support for Long Logical Sectors and Long Physical Sectors Matthew Wilcox
2008-08-05 20:46 ` Alan Cox
2008-08-06 2:22 ` Matthew Wilcox
2008-08-06 9:06 ` Alan Cox
2008-08-06 13:11 ` Matthew Wilcox
2008-08-06 14:13 ` Alan Cox
2008-08-06 15:13 ` Matthew Wilcox
2008-08-06 15:06 ` Alan Cox
2008-08-17 23:19 ` Jeff Garzik
2008-08-18 18:15 ` Matthew Wilcox
2008-08-18 18:06 ` Alan Cox [this message]
2008-08-18 18:42 ` Matthew Wilcox
2008-08-18 18:49 ` Alan Cox
2008-08-18 19:04 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818190629.22fd618c@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Matt_Domsch@dell.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®