mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: David Vrabel <david.vrabel@csr.com>
Cc: Kernel development list <linux-kernel@vger.kernel.org>,
	e1000-devel@lists.sourceforge.net, jeffrey.t.kirsher@intel.com,
	"Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Subject: Re: e1000e: 2.6.27-rc1 corrupts EEPROM/NVM
Date: Tue, 19 Aug 2008 03:02:21 -0700	[thread overview]
Message-ID: <20080819030221.728cc549.akpm@linux-foundation.org> (raw)
In-Reply-To: <48AA9757.3090002@csr.com>

On Tue, 19 Aug 2008 10:50:15 +0100 David Vrabel <david.vrabel@csr.com> wrote:

> Andrew Morton wrote:
> > On Fri, 08 Aug 2008 11:47:51 +0100 David Vrabel <david.vrabel@csr.com> wrote:
> > 
> >> 2.6.27-rc1 kernels appear to corrupt the EEPROM/NVM of the 8086:294c
> >> ethernet device (ICH9 I think).  After hacking the driver to ignore the
> >> bad CRC and MAC address I could view the EEPROM with ethtool and it was
> >> all 0xff.
> >>
> >> Testing EEPROM reads and writes with ethtool appeared to work but after
> >> a reboot of the system the ethernet device (see lspci -v output) was no
> >> longer present.  Could invalid EEPROM contents with a valid CRC (as
> >> would be the case after my read/write tests) result in the device
> >> failing to enumerate on the PCIe bus?
> 
> FYI, Jesse Brandeburg replied off-list and said that a corrupt EEPROM
> with a valid CRC can result in the device failing to enumerate.

I seem to recall one David S. Miller expressing strong opposition to
the e100[0] policy of escalating a dud EEPROM into a dead device.

> > Is this still happening in Linus's current tree?
> 
> I don't know, and I'm reluctant to try until I have a reliable way to
> restore an erased EEPROM.
> 
> > Was 2.6.26 OK?
> 
> 2.6.26 was fine.
> 

So we don't know why it corrupted the EEPROM?

      reply	other threads:[~2008-08-19 10:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 10:47 David Vrabel
2008-08-19  5:40 ` Andrew Morton
2008-08-19  9:50   ` David Vrabel
2008-08-19 10:02     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819030221.728cc549.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=david.vrabel@csr.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome