From: Adrian Bunk <bunk@kernel.org>
To: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: inclusion of <endian.h> in a kernel header? ok or not?
Date: Tue, 19 Aug 2008 22:52:39 +0300 [thread overview]
Message-ID: <20080819195239.GA21209@cs181140183.pp.htv.fi> (raw)
In-Reply-To: <ac9c93b10808191216q64c41222n7752c24c089e3303@mail.gmail.com>
On Tue, Aug 19, 2008 at 09:16:56PM +0200, Frans Meulenbroeks wrote:
> Is it ok to #include <endian.h> in a kernel header file.
> This is done in linux/patchkey.h and linux/soundcard.h but other
> places seem to prefer <asm/byteorder.h>
>...
Look at the two files you mention - they only do it in userspace.
And considering that these only users in the kernel are in the OSS code
it's most likely not the best solution.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-08-19 19:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 19:16 Frans Meulenbroeks
2008-08-19 19:52 ` Adrian Bunk [this message]
2008-08-19 21:06 ` Frans Meulenbroeks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819195239.GA21209@cs181140183.pp.htv.fi \
--to=bunk@kernel.org \
--cc=fransmeulenbroeks@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®