mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Matt Carlson" <mcarlson@broadcom.com>
To: "Marc Haber" <mh+linux-kernel@zugschlus.de>
Cc: "Michael Chan" <mchan@broadcom.com>,
	"David Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Matthew Carlson" <mcarlson@broadcom.com>
Subject: Re: 2.6.26/tg3 ping roundtrip times > 2000 ms on local network
Date: Tue, 19 Aug 2008 15:30:25 -0700	[thread overview]
Message-ID: <20080819223025.GA11221@xw6200.broadcom.net> (raw)
In-Reply-To: <20080819221439.GA19106@torres.zugschlus.de>

[-- Attachment #1: Type: text/plain, Size: 1001 bytes --]

Can you try the attached patch?  The patch reduces the delay back to
what it should have been.  If this helps, then it means you are being
bitten by the same bug the upstream patch fixed.

On Tue, Aug 19, 2008 at 03:14:39PM -0700, Marc Haber wrote:
> On Tue, Aug 19, 2008 at 10:29:22AM -0700, Michael Chan wrote:
> > It has been fixed a few days ago in the net-2.6 tree:
> >
> > tg3: Fix firmware event timeouts
> >
> > and it should be in Linus' tree very soon.  This reminds us to send the
> > same patch to -stable.
> 
> Not having much clue about git, can you send me the patch to try
> locally?
> 
> I am not even sure to have a network issue here.
> 
> Greetings
> Marc
> 
> --
> -----------------------------------------------------------------------------
> Marc Haber         | "I don't trust Computers. They | Mailadresse im Header
> Mannheim, Germany  |  lose things."    Winona Ryder | Fon: *49 621 72739834
> Nordisch by Nature |  How to make an American Quilt | Fax: *49 3221 2323190
> 

[-- Attachment #2: timeout.patch --]
[-- Type: text/plain, Size: 434 bytes --]

diff -Nrup a/drivers/net/tg3.c b/drivers/net/tg3.c
--- a/drivers/net/tg3.c	2008-08-06 09:19:01.000000000 -0700
+++ b/drivers/net/tg3.c	2008-08-19 15:26:50.000000000 -0700
@@ -1677,7 +1677,7 @@ static void tg3_wait_for_event_ack(struc
 	int i;
 
 	/* Wait for up to 2.5 milliseconds */
-	for (i = 0; i < 250000; i++) {
+	for (i = 0; i < 250; i++) {
 		if (!(tr32(GRC_RX_CPU_EVENT) & GRC_RX_CPU_DRIVER_EVENT))
 			break;
 		udelay(10);

  reply	other threads:[~2008-08-19 22:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 17:20 Marc Haber
2008-08-19 20:20 ` David Miller
2008-08-19 17:29   ` Michael Chan
2008-08-19 22:14     ` Marc Haber
2008-08-19 22:30       ` Matt Carlson [this message]
2008-08-20 17:47         ` Marc Haber
2008-08-20 14:11           ` Michael Chan
2008-08-21 16:09             ` Marc Haber
2008-08-21 16:21               ` Michael Chan
2008-08-22 11:33                 ` Marc Haber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819223025.GA11221@xw6200.broadcom.net \
    --to=mcarlson@broadcom.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchan@broadcom.com \
    --cc=mh+linux-kernel@zugschlus.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®