From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Dave Jones <davej@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Greg KH <greg@kroah.com>, Randy Dunlap <randy.dunlap@oracle.com>,
Kay Sievers <kay.sievers@vrfy.org>,
Rodolfo Giometti <giometti@linux.it>
Subject: Re: [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods.
Date: Tue, 19 Aug 2008 22:58:08 +0100 [thread overview]
Message-ID: <20080819225808.05c96802@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1219182612-13814-7-git-send-email-giometti@linux.it>
On Tue, 19 Aug 2008 23:50:08 +0200
Rodolfo Giometti <giometti@linux.it> wrote:
> Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> ---
> drivers/char/n_tty.c | 54 +++++++++++++++++++++++++++++--------------------
> include/linux/tty.h | 16 ++++++++++++++
> 2 files changed, 48 insertions(+), 22 deletions(-)
Renames are really not part of the same change set but very sensible so
no objection. EXPORT_SYMBOL_GPL please - pps is (with permission)
sticking its nose into the innards of n_tty. Those are not good general
interfaces however.
With the small changes noted I'm happy for the tty stuff to go upstream.
next prev parent reply other threads:[~2008-08-19 22:16 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 21:50 LinuxPPS (RESUBMIT 6): the PPS Linux implementation Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 01/10] LinuxPPS core support Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 02/10] PPS: userland header file for PPS API Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 03/10] PPS: documentation programs and examples Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 04/10] PPS: LinuxPPS clients support Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 07/10] tty: new PPS line discipline Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 08/10] PPS: serial clients support Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 09/10] PPS: low level IRQ timestamps recording Rodolfo Giometti
2008-08-19 21:50 ` [PATCH 10/10] PPS: parallel port clients support Rodolfo Giometti
2008-08-20 10:31 ` [PATCH 09/10] PPS: low level IRQ timestamps recording Ingo Molnar
2008-08-20 13:01 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2008-08-20 13:48 ` Ingo Molnar
2008-08-20 14:05 ` Rodolfo Giometti
2008-08-19 21:56 ` [PATCH 08/10] PPS: serial clients support Alan Cox
2008-08-19 21:54 ` [PATCH 07/10] tty: new PPS line discipline Alan Cox
2008-08-19 21:58 ` Alan Cox [this message]
2008-08-19 21:53 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Alan Cox
2008-08-19 22:49 ` Rodolfo Giometti
2008-08-19 22:38 ` Alan Cox
2008-08-19 23:05 ` Rodolfo Giometti
2008-08-20 8:53 ` Rodolfo Giometti
2008-08-20 10:11 ` Alan Cox
2008-08-19 23:22 ` [PATCH 01/10] LinuxPPS core support H. Peter Anvin
2008-08-20 9:13 ` Rodolfo Giometti
2008-08-20 13:16 LinuxPPS (RESUBMIT 7): the PPS Linux implementation Rodolfo Giometti
2008-08-20 13:16 ` [PATCH 01/10] LinuxPPS core support Rodolfo Giometti
2008-08-20 13:16 ` [PATCH 02/10] PPS: userland header file for PPS API Rodolfo Giometti
2008-08-20 13:16 ` [PATCH 03/10] PPS: documentation programs and examples Rodolfo Giometti
2008-08-20 13:16 ` [PATCH 04/10] PPS: LinuxPPS clients support Rodolfo Giometti
2008-08-20 13:16 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2008-08-20 13:16 ` [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods Rodolfo Giometti
2008-09-10 7:52 LinuxPPS (RESUBMIT 7): the PPS Linux implementation Rodolfo Giometti
2008-09-10 7:52 ` [PATCH 01/10] LinuxPPS core support Rodolfo Giometti
2008-09-10 7:52 ` [PATCH 02/10] PPS: userland header file for PPS API Rodolfo Giometti
2008-09-10 7:52 ` [PATCH 03/10] PPS: documentation programs and examples Rodolfo Giometti
2008-09-10 7:52 ` [PATCH 04/10] PPS: LinuxPPS clients support Rodolfo Giometti
2008-09-10 7:52 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2008-09-10 7:52 ` [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods Rodolfo Giometti
2008-10-02 7:41 LinuxPPS (RESUBMIT 7): the PPS Linux implementation Rodolfo Giometti
2008-10-02 7:41 ` [PATCH 01/10] LinuxPPS core support Rodolfo Giometti
2008-10-02 7:41 ` [PATCH 02/10] PPS: userland header file for PPS API Rodolfo Giometti
2008-10-02 7:41 ` [PATCH 03/10] PPS: documentation programs and examples Rodolfo Giometti
2008-10-02 7:41 ` [PATCH 04/10] PPS: LinuxPPS clients support Rodolfo Giometti
2008-10-02 7:41 ` [PATCH 05/10] ldisc: new dcd_change() method for line disciplines Rodolfo Giometti
2008-10-02 7:41 ` [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819225808.05c96802@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=giometti@linux.it \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®