From: Matt Helsley <matthltc@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
Linux-Kernel <linux-kernel@vger.kernel.org>,
Linux Containers <containers@lists.linux-foundation.org>,
linux-pm@lists.linux-foundation.org
Subject: [PATCH 2/6] Container Freezer: uninline thaw_process()
Date: Tue, 19 Aug 2008 16:22:34 -0700 [thread overview]
Message-ID: <20080819232233.732140572@us.ibm.com> (raw)
In-Reply-To: <20080819232232.432973784@us.ibm.com>
Now that the cgroup freezer system also calls thaw_process() inlining these
functions uses more space. Uninlining returns some space:
Before:
text data bss dec hex filename
4260872 275532 290816 4827220 49a854 vmlinux
After:
text data bss dec hex filename
4260852 275532 290816 4827200 49a840 vmlinux
Signed-off-by: Matt Helsley <matthltc@us.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
---
include/linux/freezer.h | 29 +++--------------------------
kernel/freezer.c | 31 +++++++++++++++++++++++++++++++
2 files changed, 34 insertions(+), 26 deletions(-)
Index: linux-2.6.27-rc1-mm1/include/linux/freezer.h
===================================================================
--- linux-2.6.27-rc1-mm1.orig/include/linux/freezer.h
+++ linux-2.6.27-rc1-mm1/include/linux/freezer.h
@@ -46,34 +46,11 @@ static inline bool should_send_signal(st
/*
* Wake up a frozen process
- *
- * task_lock() is needed to prevent the race with refrigerator() which may
- * occur if the freezing of tasks fails. Namely, without the lock, if the
- * freezing of tasks failed, thaw_tasks() might have run before a task in
- * refrigerator() could call frozen_process(), in which case the task would be
- * frozen and no one would thaw it.
*/
-static inline int __thaw_process(struct task_struct *p)
-{
- if (frozen(p)) {
- p->flags &= ~PF_FROZEN;
- return 1;
- }
- clear_freeze_flag(p);
- return 0;
-}
+extern int __thaw_process(struct task_struct *p);
-static inline int thaw_process(struct task_struct *p)
-{
- task_lock(p);
- if (__thaw_process(p) == 1) {
- task_unlock(p);
- wake_up_process(p);
- return 1;
- }
- task_unlock(p);
- return 0;
-}
+/* Takes and releases task alloc lock using task_lock() */
+extern int thaw_process(struct task_struct *p);
extern void refrigerator(void);
extern int freeze_processes(void);
Index: linux-2.6.27-rc1-mm1/kernel/freezer.c
===================================================================
--- linux-2.6.27-rc1-mm1.orig/kernel/freezer.c
+++ linux-2.6.27-rc1-mm1/kernel/freezer.c
@@ -120,3 +120,34 @@ void cancel_freezing(struct task_struct
spin_unlock_irqrestore(&p->sighand->siglock, flags);
}
}
+
+/*
+ * Wake up a frozen process
+ *
+ * task_lock() is needed to prevent the race with refrigerator() which may
+ * occur if the freezing of tasks fails. Namely, without the lock, if the
+ * freezing of tasks failed, thaw_tasks() might have run before a task in
+ * refrigerator() could call frozen_process(), in which case the task would be
+ * frozen and no one would thaw it.
+ */
+int __thaw_process(struct task_struct *p)
+{
+ if (frozen(p)) {
+ p->flags &= ~PF_FROZEN;
+ return 1;
+ }
+ clear_freeze_flag(p);
+ return 0;
+}
+
+int thaw_process(struct task_struct *p)
+{
+ task_lock(p);
+ if (__thaw_process(p) == 1) {
+ task_unlock(p);
+ wake_up_process(p);
+ return 1;
+ }
+ task_unlock(p);
+ return 0;
+}
--
next prev parent reply other threads:[~2008-08-19 23:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-19 23:22 [PATCH 0/6] Container Freezer: fixes for -mm Matt Helsley
2008-08-19 23:22 ` [PATCH 1/6] Container Freezer: Fix freezer Kconfig Matt Helsley
2008-08-20 16:42 ` Pavel Machek
2008-08-19 23:22 ` Matt Helsley [this message]
2008-08-20 16:44 ` [PATCH 2/6] Container Freezer: uninline thaw_process() Pavel Machek
2008-08-19 23:22 ` [PATCH 3/6] Container Freezer: Make freezer state names less generic Matt Helsley
2008-08-19 23:22 ` [PATCH 4/6] Container Freezer: Cleanup comment Matt Helsley
2008-08-19 23:22 ` [PATCH 5/6] Container Freezer: Rename check_if_frozen() Matt Helsley
2008-08-19 23:22 ` [PATCH 6/6] Container Freezer: Document the cgroup freezer subsystem Matt Helsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080819232233.732140572@us.ibm.com \
--to=matthltc@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome