From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] ftrace: handle weak symbol functions
Date: Wed, 20 Aug 2008 16:51:05 +0200 [thread overview]
Message-ID: <20080820145105.GB829@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0808200049140.13132@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> During tests and checks, I've discovered that there were failures to
> convert mcount callers into nops. Looking deeper into these failures,
> code that was attempted to be changed was not an mcount caller. The
> current code only updates if the code being changed is what it
> expects, but I still investigate any time there is a failure.
>
> What was happening is that a weak symbol was being used as a reference
> for other mcount callers. That weak symbol was also referenced
> elsewhere so the offsets were using the strong symbol and not the
> function symbol that it was referenced from.
>
> This patch changes the setting up of the mcount_loc section to search
> for a global function that is not weak. It will pick a local over a
> weak but if only a weak is found in a section, a warning is printed
> and the mcount location is not recorded (just to be safe).
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
applied to tip/tracing/ftrace, thanks Steve!
Ingo
prev parent reply other threads:[~2008-08-20 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 14:07 Steven Rostedt
2008-08-20 14:51 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080820145105.GB829@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®