From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755964AbYHUHNc (ORCPT ); Thu, 21 Aug 2008 03:13:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752221AbYHUHNX (ORCPT ); Thu, 21 Aug 2008 03:13:23 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:53219 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751893AbYHUHNW (ORCPT ); Thu, 21 Aug 2008 03:13:22 -0400 Date: Thu, 21 Aug 2008 00:13:22 -0700 (PDT) Message-Id: <20080821.001322.236658980.davem@davemloft.net> To: akpm@linux-foundation.org Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@linux-foundation.org, tokunaga.keiich@jp.fujitsu.com Subject: Re: [RFC][PATCH 2/2] quicklist shouldn't be proportional to # of CPUs From: David Miller In-Reply-To: <20080820234615.258a9c04.akpm@linux-foundation.org> References: <20080820195021.12E7.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080820200709.12F0.KOSAKI.MOTOHIRO@jp.fujitsu.com> <20080820234615.258a9c04.akpm@linux-foundation.org> X-Mailer: Mew version 5.2 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrew Morton Date: Wed, 20 Aug 2008 23:46:15 -0700 > On Wed, 20 Aug 2008 20:08:13 +0900 KOSAKI Motohiro wrote: > > > + num_cpus_per_node = cpus_weight_nr(node_to_cpumask(node)); > > sparc64 allmodconfig: > > mm/quicklist.c: In function `max_pages': > mm/quicklist.c:44: error: invalid lvalue in unary `&' > > we seem to have a made a spectacular mess of cpumasks lately. It should explode similarly on x86, since it also defines node_to_cpumask() as an inline function. IA64 seems to be one of the few platforms to define this as a macro evaluating to the node-to-cpumask array entry, so it's clear what platform Motohiro-san did build testing on :-)