From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758552AbYHUKbq (ORCPT ); Thu, 21 Aug 2008 06:31:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753762AbYHUKbi (ORCPT ); Thu, 21 Aug 2008 06:31:38 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:36209 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752993AbYHUKbi (ORCPT ); Thu, 21 Aug 2008 06:31:38 -0400 Date: Thu, 21 Aug 2008 12:31:17 +0200 From: Ingo Molnar To: Steven Rostedt Cc: LKML , Thomas Gleixner , Peter Zijlstra , Andrew Morton , Linus Torvalds , Benjamin Herrenschmidt Subject: Re: [PATCH] ftrace: x86 use copy to and from user functions Message-ID: <20080821103117.GB19452@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt wrote: > The modification of code is performed either by kstop_machine, before > SMP starts, or on module code before the module is executed. There is > no reason to do the modifications from assembly. The copy to and from > user functions are sufficient and produces cleaner and easier to read > code. > > Thanks to Benjamin Herrenschmidt for suggesting the idea. > > Signed-off-by: Steven Rostedt applied to tip/tracing/ftrace - thanks Steve! Ingo