mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Jack Steiner <steiner@sgi.com>
Subject: Re: [PATCH] x86: silence section mismatch warning - uv_cpu_init
Date: Thu, 21 Aug 2008 12:34:44 +0200	[thread overview]
Message-ID: <20080821103444.GE19452@elte.hu> (raw)
In-Reply-To: <1219259268-5868-2-git-send-email-marcin.slusarz@gmail.com>


* Marcin Slusarz <marcin.slusarz@gmail.com> wrote:

> WARNING: vmlinux.o(.cpuinit.text+0x3cc4): Section mismatch in reference from the function uv_cpu_init() to the function .init.text:uv_system_init()
> The function __cpuinit uv_cpu_init() references
> a function __init uv_system_init().
> If uv_system_init is only used by uv_cpu_init then
> annotate uv_system_init with a matching annotation.
> 
> uv_system_init was ment to be called only once, so make explicit by 
> creating properly-named function and annotate it as __ref.
> 
> Old code relied on uv_node_to_blade being initialized to 0, but it'a 
> not initialized from anywhere and it's not static either.

this needs a proper fix as the patch is too ugly. If something should be 
called only once then it has to go into a codepath that will only 
initialize it once.

	Ingo

  reply	other threads:[~2008-08-21 10:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-20 19:07 Marcin Slusarz
2008-08-21 10:34 ` Ingo Molnar [this message]
2008-08-21 18:49   ` Marcin Slusarz
2008-08-22  6:19     ` Ingo Molnar
2008-08-22 11:31       ` Jack Steiner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080821103444.GE19452@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcin.slusarz@gmail.com \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®