From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758257AbYHUKnU (ORCPT ); Thu, 21 Aug 2008 06:43:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753478AbYHUKnL (ORCPT ); Thu, 21 Aug 2008 06:43:11 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:40469 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753283AbYHUKnK (ORCPT ); Thu, 21 Aug 2008 06:43:10 -0400 Date: Thu, 21 Aug 2008 12:42:52 +0200 From: Ingo Molnar To: Jeremy Fitzhardinge Cc: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH] x86: export pv_lock_ops non-GPL Message-ID: <20080821104252.GA26516@elte.hu> References: <48AC62EB.6060804@goop.org> <20080821091051.GA1683@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080821091051.GA1683@elte.hu> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Ingo Molnar wrote: > * Jeremy Fitzhardinge wrote: > > > None of the spinlock API is exported GPL, so there's no reason for > > pv_lock_ops to be. > > uhm, why is this even a question? All of this stuff is so deep inside > the guts of the kernel ... so nope - if then we want to change the > others to _GPL exports as well, just to make sure nobody gets funny > ideas. i've nevertheless applied it to tip/x86/urgent - but it would be nice to clean all of this up and only export the minimally necessary (ex include file inline functions) APIs and none of the paravirt stuff. Ingo