From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: apic version warning.
Date: Thu, 21 Aug 2008 18:33:56 +0400 [thread overview]
Message-ID: <20080821143356.GA7214@lenovo> (raw)
In-Reply-To: <86802c440808210101u1101b480p74ee387082ebdcb6@mail.gmail.com>
[Yinghai Lu - Thu, Aug 21, 2008 at 01:01:19AM -0700]
| after following patch,
|
| commit 1b313f4a6d7bee7b2c034b3f1e203bc360a71cca
| Author: Cyrill Gorcunov <gorcunov@gmail.com>
| Date: Mon Aug 18 20:45:57 2008 +0400
|
| x86: apic - generic_processor_info
|
| - use physid_set instead of phys_cpu and physids_or
| - set phys_cpu_present_map bit AFTER check for allowed
| number of processors
| - add checking for APIC valid version in 64bit mode
| (mostly not needed but added for merging purpose)
| - add apic_version definition for 64bit mode which
| is used now
|
| we are getting warning for acpi path on 64 bit system
|
| please add #ifdef for that.
| actually, 64 bit doesn't use that apic_version[]
|
|
| or using following patch?
|
| diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
| index 301678b..fc64412 100644
| --- a/arch/x86/kernel/acpi/boot.c
| +++ b/arch/x86/kernel/acpi/boot.c
| @@ -252,10 +252,8 @@ static void __cpuinit acpi_register_lapic(int id,
| u8 enabled)
| return;
| }
|
| -#ifdef CONFIG_X86_32
| if (boot_cpu_physical_apicid != -1U)
| ver = apic_version[boot_cpu_physical_apicid];
| -#endif
|
| generic_processor_info(id, ver);
| }
| @@ -775,10 +773,8 @@ static void __init
| acpi_register_lapic_address(unsigned long address)
| set_fixmap_nocache(FIX_APIC_BASE, address);
| if (boot_cpu_physical_apicid == -1U) {
| boot_cpu_physical_apicid = read_apic_id();
| -#ifdef CONFIG_X86_32
| apic_version[boot_cpu_physical_apicid] =
| GET_APIC_VERSION(apic_read(APIC_LVR));
| -#endif
| }
| }
|
|
| YH
|
Thanks, Yinghai!
- Cyrill -
prev parent reply other threads:[~2008-08-21 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-21 8:01 Yinghai Lu
2008-08-21 8:54 ` Ingo Molnar
2008-08-21 14:33 ` Cyrill Gorcunov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080821143356.GA7214@lenovo \
--to=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®