mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Petr Baudis <pasky@suse.cz>,
	Alan.Brunelle@hp.com, linux-kernel@vger.kernel.org,
	git@vger.kernel.org
Subject: Re: Linux 2.6.27-rc3: kernel BUG at mm/vmalloc.c - bisected
Date: Fri, 22 Aug 2008 15:48:46 -0400	[thread overview]
Message-ID: <20080822194846.GA31356@coredump.intra.peff.net> (raw)
In-Reply-To: <20080822193730.GA1598@atjola.homenet>

On Fri, Aug 22, 2008 at 09:37:30PM +0200, Björn Steinbrink wrote:

> Yep, and that's totally correct as far as bisect is concerned. The
> parents of that merge commit are:
> 88fa08f67bee1a0c765237bdac106a32872f57d2
> b1b135c8d619cb2c7045d6ee4e48375882518bb5
> 
> And Alan marked both of them as good.
> 
> So, unless Alan made a mistake during his bisection, each of the
> branches is correct, but the merge did not lead to a correct result. So
> while there were no textual conflicts, there were still incompatible
> changes regarding the code semantics and compatibility was not restored
> during the merge.

One thing that I have seen proposed (but never tried myself) is that you
can linearize the changes using "rebase -i" (or cherry-picking), and
then bisect that result. That is, given a history

A-B-C-D
 \   /
  E-F

where the merge "D" introduces the bug, you could try creating:

  A-B-C-E'-F'

and bisecting that. And you should know that C is good from your
previous bisection, but that F' probably is not, since it should be
textually the same as D (unless, of course, you had textual conflicts
during the rebase that you fixed up differently).

So in essence you are testing each of E and F, but based on the other
work. So you should be able to find the one patch that causes the
conflict. And depending on the conflict, you may get more information by
doing it the other way. I.e.,:

  A-E-F-B'-C'

-Peff

  parent reply	other threads:[~2008-08-22 19:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-13 23:03 Alan D. Brunelle
2008-08-13 23:27 ` Alan D. Brunelle
2008-08-14 16:14 ` Rafael J. Wysocki
2008-08-14 19:21   ` Alan D. Brunelle
2008-08-14 20:29     ` Rafael J. Wysocki
2008-08-19 19:46 ` Andrew Morton
2008-08-22 15:37   ` Alan D. Brunelle
2008-08-22 16:25     ` Andrew Morton
2008-08-22 17:16       ` Petr Baudis
2008-08-22 17:51         ` Andrew Morton
2008-08-22 18:07           ` Alan D. Brunelle
2008-08-22 19:37           ` Björn Steinbrink
2008-08-22 19:47             ` Alan D. Brunelle
2008-08-22 20:17               ` Alan D. Brunelle
2008-08-22 19:48             ` Jeff King [this message]
2008-08-22 21:05           ` Junio C Hamano
2008-08-22 21:16             ` Andrew Morton
2008-08-22 21:21               ` Jeff King
2008-08-22 21:36               ` Björn Steinbrink
2008-08-25 18:14   ` Vegard Nossum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080822194846.GA31356@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=Alan.Brunelle@hp.com \
    --cc=B.Steinbrink@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=git@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pasky@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®