mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, zohar@us.ibm.com,
	dvelarde@us.ibm.com, serue@us.ibm.com, safford@us.ibm.com
Subject: Re: [PATCH][resubmit] TPM: update char dev BKL pushdown
Date: Tue, 26 Aug 2008 22:08:23 +0100	[thread overview]
Message-ID: <20080826220823.509571fd@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1219784185.4768.6.camel@blackbox>

> +	atomic_set(&chip->is_open, 1);
> +	get_device(chip->dev); /* protect from chip disappearing */

Why not just use test_and_set_bit() ? You seem to be abusing atomic_t to
achieve this.

  reply	other threads:[~2008-08-26 21:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26 20:56 Rajiv Andrade
2008-08-26 21:08 ` Alan Cox [this message]
2008-08-27  3:19   ` Serge E. Hallyn
2008-08-27 14:32     ` Rajiv Andrade
2008-08-26 21:29 ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080826220823.509571fd@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=dvelarde@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=safford@us.ibm.com \
    --cc=serue@us.ibm.com \
    --cc=srajiv@linux.vnet.ibm.com \
    --cc=zohar@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®