From: David Miller <davem@davemloft.net>
To: dhowells@redhat.com
Cc: harvey.harrison@gmail.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] afs: fsclient.c sparse endian annotations of operation_ID
Date: Wed, 27 Aug 2008 04:17:05 -0700 (PDT) [thread overview]
Message-ID: <20080827.041705.160546703.davem@davemloft.net> (raw)
In-Reply-To: <28254.1219835544@redhat.com>
From: David Howells <dhowells@redhat.com>
Date: Wed, 27 Aug 2008 12:12:24 +0100
> Harvey Harrison <harvey.harrison@gmail.com> wrote:
>
> > + if (call->operation_ID != __constant_htonl(FSFETCHDATA64)) {
>
> Doesn't htonl() resolve to this for a constant argument? Following through
> the definitions, it certainly looks like it ought to:
Yes it does.
The __constant_*() interfaces should only be uses for things that
must be evaluated at compile time (static data initializations,
switch statement case values etc.).
next prev parent reply other threads:[~2008-08-27 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 22:05 Harvey Harrison
2008-08-27 11:12 ` David Howells
2008-08-27 11:17 ` David Miller [this message]
2008-08-28 2:22 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080827.041705.160546703.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®