Re: [PATCH] PCI PM: Introduce function pci_wake_from_d3 (rev. 2)

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Monday, August 18, 2008 12:38 pm Rafael J. Wysocki wrote:
> [Sorry, it is more useful to define the function so that it takes a second
> argument indicating whether to enable or disable wake-up.]
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> PCI PM: Introduce function pci_wake_from_d3 (rev. 2)
>
> Many device drivers use the following sequence of statements to
> enable the device to wake up the system while being in the D3_hot
> or D3_cold low power state:
>
> 	pci_enable_wake(pdev, PCI_D3hot, 1);
> 	pci_enable_wake(pdev, PCI_D3cold, 1);
>
> However, the second call is not necessary if the first one succeeds
> (the ordering of the statements above doesn't matter here) and it
> may even be harmful, because we are not supposed to enable PME#
> after the wake-up power has been enabled for the device.
>
> To allow drivers to overcome this problem, introduce function
> pci_wake_from_d3() that will enable the device to wake up the system
> from any of D3_hot and D3_cold as long as the wake-up from at least
> one of them is supported.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

Applied to linux-next, thanks Rafael.

Jesse