From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] ftrace: remove direct reference to mcount in trace code
Date: Thu, 28 Aug 2008 09:50:26 +0200 [thread overview]
Message-ID: <20080828075023.GI21875@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0808272323030.1782@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> The mcount record method of ftrace scans objdump for references to
> mcount. Using mcount as the reference to test if the calls to mcount
> being replaced are indeed calls to mcount, this use of mcount was also
> caught as a location to change. Using a variable that points to the
> mcount address moves this reference into the data section that is not
> scanned, and we do not use a false location to try and modify.
>
> The warn on code was what was used to detect this bug.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
applied to tip/tracing/ftrace - thanks Steve!
Ingo
prev parent reply other threads:[~2008-08-28 7:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 3:24 Steven Rostedt
2008-08-28 7:50 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080828075023.GI21875@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®