From: Andrew Morton <akpm@linux-foundation.org>
To: aaron@merfinllc.com, mpm@selenic.com,
linux-kernel@vger.kernel.org, tytso@mit.edu, stable@kernel.org
Subject: Re: drivers/char/random.c line 728 BUG
Date: Fri, 29 Aug 2008 12:54:45 -0700 [thread overview]
Message-ID: <20080829125445.9e48b1f1.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080829124807.54293904.akpm@linux-foundation.org>
On Fri, 29 Aug 2008 12:48:07 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:
> We could fix this by moving the assertion inside the lock, but it seems
> safer and saner to revert to the old behaviour wherein
> entropy_store.entropy_count at no time exceeds
> entropy_store.poolinfo->POOLBITS.
The fixed version even generates improved code.
Let's try to avoid repeats:
--- a/drivers/char/random.c~drivers-char-randomc-fix-a-race-which-can-lead-to-a-bogus-bug-fix
+++ a/drivers/char/random.c
@@ -407,7 +407,7 @@ struct entropy_store {
/* read-write data: */
spinlock_t lock;
unsigned add_ptr;
- int entropy_count;
+ int entropy_count; /* Must at no time exceed ->POOLBITS! */
int input_rotate;
};
_
next prev parent reply other threads:[~2008-08-29 19:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-26 22:59 Aaron Straus
2008-08-28 22:59 ` Aaron Straus
2008-08-29 19:48 ` Andrew Morton
2008-08-29 19:54 ` Andrew Morton [this message]
2008-08-29 22:31 ` Aaron Straus
2008-08-29 22:42 ` Andrew Morton
2008-09-03 18:18 ` Matt Mackall
2008-09-03 18:28 ` Aaron Straus
2008-09-03 22:12 ` Matt Mackall
2008-09-03 22:32 ` Andrew Morton
2008-09-03 22:51 ` Matt Mackall
2008-09-03 23:12 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080829125445.9e48b1f1.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aaron@merfinllc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=stable@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®