From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: david@fries.net, linux-kernel@vger.kernel.org,
p_gortmaker@yahoo.com, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] ne.c msleep not mdelay
Date: Sat, 30 Aug 2008 15:44:47 +0100 [thread overview]
Message-ID: <20080830154447.770aaca0@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20080830.233647.05599714.anemo@mba.ocn.ne.jp>
> There are already some msleep() in probe_irq_on() which is called just
> before here. And this part is not protected by any spinlock or
> preempt_disable.
>
> So, if rescheduling was dangerous here, we already have potential
> problems, no?
Yes we do but I didn't manage to stop the other mistakes getting in when
they did. If you take a schedule you get results back from the probe_irq
that tend to suck in other random ISA device events (ISA being edge
triggered nobody was ever careful about spurious irq)
next prev parent reply other threads:[~2008-08-30 15:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 2:44 David Fries
2008-08-30 8:59 ` Alan Cox
2008-08-30 14:36 ` Atsushi Nemoto
2008-08-30 14:44 ` Alan Cox [this message]
2008-08-31 17:30 ` Atsushi Nemoto
2008-08-30 14:57 ` David Fries
2008-08-30 14:58 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080830154447.770aaca0@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=anemo@mba.ocn.ne.jp \
--cc=david@fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®