mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Peter Ambroz <comp@gjh.sk>
Cc: linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: Marvell 6145 PATA controller
Date: Sun, 31 Aug 2008 10:36:08 +0100	[thread overview]
Message-ID: <20080831103608.69499247@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <48B9DCBE.3000306@gjh.sk>

> The second solution is to remove few lines from ahci.c which lists the 
> marvell 6145 device (and probably also marvell 6121).
> Short patch included below.

Yes. I know or to teach the AHCI driver how to drive the PATA part of the
device. Unfortunately I've been trying - privately and now publically to
get Jeff Garzik to fix that one for *months*.

I also don't have the docs for it and requests to Jeff for the relevant
documentation have never received replies even to confirm if he has it

> ----------CUT-----------
> --- drivers/ata/ahci.c	2008-08-28 23:11:37.000000000 +0200
> +++ drivers/ata/ahci.c	2008-08-30 20:08:59.000000000 +0200
> @@ -590,10 +590,6 @@
>   	{ PCI_VDEVICE(SI, 0x1185), board_ahci }, /* SiS 966 */
>   	{ PCI_VDEVICE(SI, 0x0186), board_ahci }, /* SiS 968 */
> 
> -	/* Marvell */
> -	{ PCI_VDEVICE(MARVELL, 0x6145), board_ahci_mv },	/* 6145 */
> -	{ PCI_VDEVICE(MARVELL, 0x6121), board_ahci_mv },	/* 6121 */
> -
>   	/* Generic, PCI class code for AHCI */
>   	{ PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>   	  PCI_CLASS_STORAGE_SATA_AHCI, 0xffffff, board_ahci },
> ----------CUT-----------

And you can have my ack for it, but don't expect anything to happen

(and yes I *am* cross about this)

Alan

  reply	other threads:[~2008-08-31  9:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-30 23:50 Peter Ambroz
2008-08-31  9:36 ` Alan Cox [this message]
2008-08-31 11:04   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080831103608.69499247@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=comp@gjh.sk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®