From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: david@fries.net
Cc: linux-kernel@vger.kernel.org, p_gortmaker@yahoo.com,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ne.c fix, res->name
Date: Mon, 01 Sep 2008 02:15:05 +0900 (JST) [thread overview]
Message-ID: <20080901.021505.108307990.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <20080830180503.GI25161@spacedout.fries.net>
On Sat, 30 Aug 2008 13:05:03 -0500, David Fries <david@fries.net> wrote:
> On Sun, Aug 31, 2008 at 12:03:57AM +0900, Atsushi Nemoto wrote:
> > On Fri, 29 Aug 2008 21:44:25 -0500, David Fries <david@fries.net> wrote:
> > > + if (!strcmp(res->name, BAD_STR))
> > > + dev->mem_end = BAD;
> >
> > The res->name might be NULL. You should check it first.
> >
> > if (res->name && !strcmp(res->name, BAD_STR))
> > dev->mem_end = BAD;
>
> The name gets a valid string by that point in time.
>
> drivers/base/platform.c:257
Oh, you are right. Sorry for noise.
---
Atsushi Nemoto
prev parent reply other threads:[~2008-08-31 17:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-30 2:44 [PATCH 1/2] ne.c fix for hibernate and rmmod oops fix David Fries
2008-08-30 15:03 ` Atsushi Nemoto
2008-08-30 18:05 ` [PATCH 1/2] ne.c fix, res->name David Fries
2008-08-31 17:15 ` Atsushi Nemoto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080901.021505.108307990.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=david@fries.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®