From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755241AbYICAZK (ORCPT ); Tue, 2 Sep 2008 20:25:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752412AbYICAYz (ORCPT ); Tue, 2 Sep 2008 20:24:55 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:60522 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752280AbYICAYy (ORCPT ); Tue, 2 Sep 2008 20:24:54 -0400 Date: Tue, 02 Sep 2008 17:24:48 -0700 (PDT) Message-Id: <20080902.172448.84151776.davem@davemloft.net> To: brunel@diku.dk Cc: kuznet@ms2.inr.ac.ru, pekkas@netcore.fi, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net/xfrm: Use an IS_ERR test rather than a NULL test From: David Miller In-Reply-To: <200809011053.34028.brunel@diku.dk> References: <200809011053.34028.brunel@diku.dk> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julien Brunel Date: Mon, 1 Sep 2008 10:53:33 +0200 > In case of error, the function xfrm_bundle_create returns an ERR > pointer, but never returns a NULL pointer. So a NULL test that comes > after an IS_ERR test should be deleted. > > The semantic match that finds this problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) > > // > @match_bad_null_test@ > expression x, E; > statement S1,S2; > @@ > x = xfrm_bundle_create(...) > ... when != x = E > * if (x != NULL) > S1 else S2 > // > > Signed-off-by: Julien Brunel > Signed-off-by: Julia Lawall Looks good, patch applied, thanks.