From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755010AbYIBWfP (ORCPT ); Tue, 2 Sep 2008 18:35:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751776AbYIBWe7 (ORCPT ); Tue, 2 Sep 2008 18:34:59 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:49528 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754867AbYIBWe6 (ORCPT ); Tue, 2 Sep 2008 18:34:58 -0400 Date: Tue, 2 Sep 2008 15:34:20 -0700 From: Andrew Morton To: Michael Halcrow Cc: viro@ZinIV.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH] eCryptfs: Remove retry loop in ecryptfs_readdir() Message-Id: <20080902153420.ac015747.akpm@linux-foundation.org> In-Reply-To: <20080902222836.GD10186@halcrowt61p.austin.ibm.com> References: <20080902222836.GD10186@halcrowt61p.austin.ibm.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Sep 2008 17:28:36 -0500 Michael Halcrow wrote: > > The retry block in ecryptfs_readdir() has been in the eCryptfs code > base for a while, apparently for no good reason. This loop could > potentially run without terminating. This patch removes the loop, > instead erroring out if vfs_readdir() on the lower file fails. I assumed this was for-2.6.28.