From: Jonathan Corbet <corbet@lwn.net>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-kernel@vger.kernel.org, devel@laptop.org
Subject: Re: [PATCH 3/3] Define and use PCI_DEVICE_ID_MARVELL_88ALP01_CCIC for CAFÉ camera driver
Date: Wed, 3 Sep 2008 09:54:46 -0600 [thread overview]
Message-ID: <20080903095446.330c70d1@bike.lwn.net> (raw)
In-Reply-To: <1220438902.2985.101.camel@pmac.infradead.org>
On Wed, 03 Sep 2008 11:48:22 +0100
David Woodhouse <dwmw2@infradead.org> wrote:
> Also, stop looking at the NAND controller (0x4100) and checking the
> device class. For a while during development, all three functions on
> the chip had the same ID. We made them fix that fairly promptly, and
> we can forget about it now.
I see no harm in having the driver check the device to ensure it's what
it thinks it is - we can probably afford the runtime overhead. But
whatever, I'm not that concerned; toss in an
Acked-by: Jonathan Corbet <corbet@lwn.net>
if you wish.
jon
prev parent reply other threads:[~2008-09-03 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1220438625.patch@pmac.infradead.org>
2008-09-03 10:48 ` [PATCH 1/3] Use PCI_DEVICE_ID_88ALP01 for CAFÉ chip, rather than PCI_DEVICE_ID_CAFE David Woodhouse
2008-09-03 14:05 ` Pierre Ossman
2008-09-03 10:48 ` [PATCH 2/3] [MTD] [NAND] Define and use PCI_DEVICE_ID_MARVELL_88ALP01_NAND for CAFÉ David Woodhouse
2008-09-03 10:48 ` [PATCH 3/3] Define and use PCI_DEVICE_ID_MARVELL_88ALP01_CCIC for CAFÉ camera driver David Woodhouse
2008-09-03 15:54 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080903095446.330c70d1@bike.lwn.net \
--to=corbet@lwn.net \
--cc=devel@laptop.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®