From: Ingo Molnar <mingo@elte.hu>
To: Rui Sousa <rui.p.m.sousa@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATH] Fix compilation when CONFIG_TRACE_IRQFLAGS_SUPPORT is not set
Date: Thu, 4 Sep 2008 16:39:18 +0200 [thread overview]
Message-ID: <20080904143918.GA28095@elte.hu> (raw)
In-Reply-To: <200809031753.07292.rui.p.m.sousa@gmail.com>
* Rui Sousa <rui.p.m.sousa@gmail.com> wrote:
> Hi,
>
> This patch fixes compilation if CONFIG_TRACE_IRQFLAGS_SUPPORT is ever
> disabled (which is currently not allowed by Kconfig). Alternatively we
> could just remove the option altogether and the associated code paths.
> Since the compilation error has been in the tree for at least two
> years and no one noticed it, I guess we don't really have the need for
> CONFIG_TRACE_IRQFLAGS_SUPPORT=n. Boot tested on x86 UP.
applied to tip/core/locking - thanks Rui.
since you fixed it i prefer the fix over the removal. We could still
remove the !TRACE_IRQFLAGS_SUPPORT now (in a separate commit) and
simpify this header a bit that way. Thus if someone needs the
!TRACE_IRQFLAGS_SUPPORT mode of build for future work, it can be
restored via a simple revert.
Ingo
next prev parent reply other threads:[~2008-09-04 14:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 15:53 Rui Sousa
2008-09-04 14:39 ` Ingo Molnar [this message]
2008-09-04 17:14 ` Hiroshi Shimamoto
2008-09-04 17:47 ` Rui Sousa
2008-09-04 18:29 ` Hiroshi Shimamoto
2008-09-05 10:57 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904143918.GA28095@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rui.p.m.sousa@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®