From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: Andy Whitcroft <apw@shadowen.org>
Cc: kosaki.motohiro@jp.fujitsu.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Mel Gorman <mel@csn.ul.ie>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer
Date: Thu, 04 Sep 2008 16:59:44 +0900 [thread overview]
Message-ID: <20080904162900.B262.KOSAKI.MOTOHIRO@jp.fujitsu.com> (raw)
In-Reply-To: <1220475206-23684-1-git-send-email-apw@shadowen.org>
> When a process enters direct reclaim it will expend effort identifying
> and releasing pages in the hope of obtaining a page. However as these
> pages are released asynchronously there is every possibility that the
> pages will have been consumed by other allocators before the reclaimer
> gets a look in. This is particularly problematic where the reclaimer is
> attempting to allocate a higher order page. It is highly likely that
> a parallel allocation will consume lower order constituent pages as we
> release them preventing them coelescing into the higher order page the
> reclaimer desires.
>
> This patch set attempts to address this for allocations above
> ALLOC_COSTLY_ORDER by temporarily collecting the pages we are releasing
> onto a local free list. Instead of freeing them to the main buddy lists,
> pages are collected and coelesced on this per direct reclaimer free list.
> Pages which are freed by other processes are also considered, where they
> coelesce with a page already under capture they will be moved to the
> capture list. When pressure has been applied to a zone we then consult
> the capture list and if there is an appropriatly sized page available
> it is taken immediatly and the remainder returned to the free pool.
> Capture is only enabled when the reclaimer's allocation order exceeds
> ALLOC_COSTLY_ORDER as free pages below this order should naturally occur
> in large numbers following regular reclaim.
Hi Andy,
I like almost part of your patch.
(at least, I can ack patch 1/4 - 3/4)
So, I worry about OOM risk.
Can you remember desired page size to capture list (or any other location)?
if possible, __capture_on_page can avoid to capture unnecessary pages.
So, if __capture_on_page() can make desired size page by buddy merging,
it can free other pages on capture_list.
In worst case, shrink_zone() is called by very much process at the same time.
Then, if each process doesn't back few pages, very many pages doesn't be backed.
next prev parent reply other threads:[~2008-09-04 8:01 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 18:44 [RFC PATCH 0/4] Reclaim page capture v2 Andy Whitcroft
2008-09-03 18:44 ` [PATCH 1/4] pull out the page pre-release and sanity check logic for reuse Andy Whitcroft
2008-09-04 1:24 ` Rik van Riel
2008-09-05 1:52 ` KOSAKI Motohiro
2008-09-03 18:44 ` [PATCH 2/4] pull out zone cpuset and watermark checks " Andy Whitcroft
2008-09-04 1:24 ` Rik van Riel
2008-09-05 1:52 ` KOSAKI Motohiro
2008-09-03 18:44 ` [PATCH 3/4] buddy: explicitly identify buddy field use in struct page Andy Whitcroft
2008-09-03 20:36 ` Christoph Lameter
2008-09-04 1:25 ` Rik van Riel
2008-09-05 1:52 ` KOSAKI Motohiro
2008-09-03 18:44 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-09-03 20:35 ` Christoph Lameter
2008-09-03 20:53 ` Andy Whitcroft
2008-09-03 21:00 ` Christoph Lameter
2008-09-04 6:38 ` Peter Zijlstra
2008-09-04 14:18 ` Christoph Lameter
2008-09-04 8:11 ` KOSAKI Motohiro
2008-09-04 8:58 ` Andy Whitcroft
2008-09-04 7:20 ` Peter Zijlstra
2008-09-04 11:35 ` Andy Whitcroft
2008-09-04 7:59 ` KOSAKI Motohiro [this message]
2008-09-04 14:44 ` Andy Whitcroft
2008-09-05 1:52 ` KOSAKI Motohiro
-- strict thread matches above, loose matches on Subject: below --
2008-10-01 12:30 [PATCH 0/4] Reclaim page capture v4 Andy Whitcroft
2008-10-01 12:31 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-10-01 15:01 ` Christoph Lameter
2008-10-02 14:35 ` Andy Whitcroft
2008-10-02 16:29 ` Christoph Lameter
2008-10-03 3:41 ` KOSAKI Motohiro
2008-10-03 12:37 ` Christoph Lameter
2008-10-02 7:24 ` KAMEZAWA Hiroyuki
2008-10-02 15:02 ` Andy Whitcroft
2008-09-05 10:19 [PATCH 0/4] Reclaim page capture v3 Andy Whitcroft
2008-09-05 10:20 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-07-01 17:58 [RFC PATCH 0/4] Reclaim page capture v1 Andy Whitcroft
2008-07-01 17:58 ` [PATCH 4/4] capture pages freed during direct reclaim for allocation by the reclaimer Andy Whitcroft
2008-07-02 12:01 ` KOSAKI Motohiro
2008-07-02 14:44 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080904162900.B262.KOSAKI.MOTOHIRO@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=apw@shadowen.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®