From: Mark Brown <broonie@sirena.org.uk>
To: Bryan Wu <cooloney@kernel.org>
Cc: Cliff Cai <cliff.cai@analog.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver
Date: Fri, 5 Sep 2008 14:10:50 +0100 [thread overview]
Message-ID: <20080905131049.GH12383@sirena.org.uk> (raw)
In-Reply-To: <1220610102-7716-3-git-send-email-cooloney@kernel.org>
On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:
> + /* Maybe the dummy buffer descriptor ring is damaged */
> + sport->dummy_rx_desc->next_desc_addr = \
> + (unsigned long)(sport->dummy_rx_desc+1);
Here and elsewhere in this driver you've got continuation characters
which aren't need. I've fixed this up locally (and some additional
checkpatch/coding standards things) here and in other patches in the
series.
Otherwise the patch series looks good to go, thanks - I'm just about to
review the codec driver patch that it depends upon.
next prev parent reply other threads:[~2008-09-05 13:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 10:21 [PATCH 0/9] ASoC Blackfin supporting (v2) Bryan Wu
2008-09-05 10:21 ` [PATCH 1/9] ASoC: add Blackfin build options to Kconfig and Makefile of sound soc framework Bryan Wu
2008-09-05 12:38 ` [alsa-devel] " Mark Brown
2008-09-05 10:21 ` [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver Bryan Wu
2008-09-05 13:10 ` Mark Brown [this message]
2008-09-05 10:21 ` [PATCH 3/9] ASoC: Blackfin: DMA Driver for AC97 sound chip Bryan Wu
2008-09-05 12:48 ` [alsa-devel] " Mark Brown
2008-09-05 10:21 ` [PATCH 4/9] ASoC: Blackfin: AC97 Blackfin CPU DAI driver Bryan Wu
2008-09-05 10:21 ` [PATCH 5/9] ASoC: Blackfin: DMA Driver for I2S sound chip Bryan Wu
2008-09-05 10:21 ` [PATCH 6/9] ASoC: Blackfin: I2S CPU DAI driver Bryan Wu
2008-09-05 10:21 ` [PATCH 7/9] ASoC: Blackfin: board driver for AD1980/1 audio codec Bryan Wu
2008-09-05 10:21 ` [PATCH 8/9] ASoC: Blackfin: board driver for SSM2602 sound chip Bryan Wu
2008-09-05 10:21 ` [PATCH 9/9] ASoC: Blackfin: add Blackfin arch ASoC Kconfig and Makefile Bryan Wu
2008-09-05 12:37 ` [alsa-devel] [PATCH 0/9] ASoC Blackfin supporting (v2) Mark Brown
2008-09-05 14:00 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905131049.GH12383@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=cooloney@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®