From: Andre Noll <maan@systemlinux.org>
To: Andrew Patterson <andrew.patterson@hp.com>
Cc: linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com,
linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk,
axboe@kernel.dk, andmike@linux.vnet.ibm.com, mike.miller@hp.com,
genanr@emsphone.com, jmoyer@redhat.com
Subject: Re: [PATCH 2/6] Adjust block device size after an online resize of a disk.
Date: Fri, 5 Sep 2008 15:12:44 +0200 [thread overview]
Message-ID: <20080905131244.GC3795@skl-net.de> (raw)
In-Reply-To: <20080904202725.10456.62289.stgit@bob.kio>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
On 14:27, Andrew Patterson wrote:
> int revalidate_disk(struct gendisk *disk)
> {
> + struct block_device *bdev;
> int ret = 0;
>
> if (disk->fops->revalidate_disk)
> ret = disk->fops->revalidate_disk(disk);
Maybe we should return early at this point if revalidate_disk()
failed or fops->revalidate_disk is NULL.
> + bdev = bdget_disk(disk, 0);
> + if (!bdev)
> + return ret;
We might return success here even if bdev is NULL. OTOH, as the callers
of revalidate_disk() do not check the return value anyway (although at
least tapeblock_revalidate_disk() might return a negative value) it's
probably also an option to change the return type of revalidate_disk()
to void.
Andre
--
The only person who always got his work done by Friday was Robinson Crusoe
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-09-05 13:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 20:27 [PATCH 0/6] detect online disk resize Andrew Patterson
2008-09-04 20:27 ` [PATCH 1/6] Wrapper for lower-level revalidate_disk routines Andrew Patterson
2008-09-04 20:27 ` [PATCH 2/6] Adjust block device size after an online resize of a disk Andrew Patterson
2008-09-05 13:12 ` Andre Noll [this message]
2008-09-05 15:36 ` Andrew Patterson
2008-09-05 17:55 ` Andre Noll
2008-09-05 20:34 ` Andrew Patterson
2008-09-04 20:27 ` [PATCH 3/6] Check for device resize when rescanning partitions Andrew Patterson
2008-09-04 20:27 ` [PATCH 4/6] SCSI sd driver calls revalidate_disk wrapper Andrew Patterson
2008-09-04 20:27 ` [PATCH 5/6] Added flush_disk to factor out common buffer cache flushing code Andrew Patterson
2008-09-04 20:27 ` [PATCH 6/6] Call flush_disk() after detecting an online resize Andrew Patterson
2008-09-05 7:02 ` [PATCH 0/6] detect online disk resize Jens Axboe
2008-09-05 8:21 ` Pasi Kärkkäinen
2008-09-05 15:15 ` Andrew Patterson
-- strict thread matches above, loose matches on Subject: below --
2008-08-29 23:12 Andrew Patterson
2008-08-29 23:13 ` [PATCH 2/6] Adjust block device size after an online resize of a disk Andrew Patterson
2008-09-03 18:17 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080905131244.GC3795@skl-net.de \
--to=maan@systemlinux.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=andmike@linux.vnet.ibm.com \
--cc=andrew.patterson@hp.com \
--cc=axboe@kernel.dk \
--cc=genanr@emsphone.com \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®