From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dyn_array: using %pF instead of print_fn_descriptor_symbol
Date: Sat, 6 Sep 2008 19:09:44 +0200 [thread overview]
Message-ID: <20080906170944.GG4856@elte.hu> (raw)
In-Reply-To: <20080829155319.dc76b1c0.akpm@linux-foundation.org>
* Andrew Morton <akpm@linux-foundation.org> wrote:
> > ptr = __alloc_bootmem_nopanic(total_size, max_align, 0);
> > if (!ptr)
> > panic("Can not alloc dyn_alloc\n");
>
> Why duplicate the panic()? Just call __alloc_bootmem().
agreed.
> > #ifdef CONFIF_GENERIC_HARDIRQS
>
> That doesn't appear to have been very well tested?
on non-genirq systems? Most likely. If then most testing they get is
from cross-build tools. Few if any actual users.
> The code has a few coding-style glitches which checkpatch can detect.
yeah. Yinghai, could you please fix them?
Ingo
next prev parent reply other threads:[~2008-09-06 17:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-29 22:07 Yinghai Lu
2008-08-29 22:20 ` Andrew Morton
2008-08-29 22:32 ` Yinghai Lu
2008-08-29 22:45 ` Andrew Morton
2008-08-29 22:53 ` Andrew Morton
2008-08-29 23:34 ` Yinghai Lu
2008-08-30 0:23 ` Andrew Morton
2008-09-06 17:09 ` Ingo Molnar [this message]
2008-09-06 17:16 ` Yinghai Lu
2008-09-06 17:18 ` Ingo Molnar
2008-09-06 17:27 ` Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080906170944.GG4856@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®