mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: linux-kernel@vger.kernel.org, svaidy@linux.vnet.ibm.com,
	peterz@infradead.org
Subject: Re: [PATCH] sched: arch_reinit_sched_domains() must destroy domains to force rebuild
Date: Sat, 6 Sep 2008 19:23:16 +0200	[thread overview]
Message-ID: <20080906172316.GK4856@elte.hu> (raw)
In-Reply-To: <1220040701-3139-1-git-send-email-maxk@qualcomm.com>


* Max Krasnyansky <maxk@qualcomm.com> wrote:

> What I realized recently is that calling rebuild_sched_domains() in
> arch_reinit_sched_domains() by itself is not enough when cpusets are enabled.
> partition_sched_domains() code is trying to avoid unnecessary domain rebuilds
> and will not actually rebuild anything if new domain masks match the old ones.
> 
> What this means is that doing
>      echo 1 > /sys/devices/system/cpu/sched_mc_power_savings
> on a system with cpusets enabled will not take affect untill something changes
> in the cpuset setup (ie new sets created or deleted).
> 
> This patch fixes restore correct behaviour where domains must be rebuilt in
> order to enable MC powersaving flags.
> 
> Test on quad-core Core2 box with both CONFIG_CPUSETS and !CONFIG_CPUSETS.
> Also tested on dual-core Core2 laptop. Lockdep is happy and things are working
> as expected.
> 
> Ingo, please apply.

applied to tip/sched/cpuset, thanks Max.

> btw We also need to push my other cpuset patch into mainline.  [...]

will push it once this has been tested some more.

	Ingo

      parent reply	other threads:[~2008-09-06 17:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29 20:11 Max Krasnyansky
2008-08-30 20:23 ` Vaidyanathan Srinivasan
2008-09-06 17:23 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080906172316.GK4856@elte.hu \
    --to=mingo@elte.hu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=peterz@infradead.org \
    --cc=svaidy@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®