From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755098AbYIGLBZ (ORCPT ); Sun, 7 Sep 2008 07:01:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753162AbYIGLBQ (ORCPT ); Sun, 7 Sep 2008 07:01:16 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41849 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbYIGLBP (ORCPT ); Sun, 7 Sep 2008 07:01:15 -0400 Date: Sun, 7 Sep 2008 04:00:09 -0700 From: Andrew Morton To: Peter Zijlstra Cc: Mike Travis , Ingo Molnar , davej@codemonkey.org.uk, David Miller , Eric Dumazet , "Eric W. Biederman" , Jack Steiner , Jeremy Fitzhardinge , Jes Sorensen , "H. Peter Anvin" , Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [RFC 07/13] sched: Reduce stack size requirements in kernel/sched.c Message-Id: <20080907040009.611ac986.akpm@linux-foundation.org> In-Reply-To: <1220783087.8687.73.camel@twins.programming.kicks-ass.net> References: <20080906235036.891970000@polaris-admin.engr.sgi.com> <20080906235037.880702000@polaris-admin.engr.sgi.com> <1220783087.8687.73.camel@twins.programming.kicks-ass.net> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 07 Sep 2008 12:24:47 +0200 Peter Zijlstra wrote: > get_online_cpus() can sleep, but you just disabled preemption with those > get_cpumask_var() horribles! make cpu_hotplug.refcount an atomic_t. > Couldn't be arsed to look through the rest, but I really hate this > cpumask_ptr() stuff that relies on disabling preemption. that's harder to fix ;)