From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753164AbYIHRLh (ORCPT ); Mon, 8 Sep 2008 13:11:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753081AbYIHRLY (ORCPT ); Mon, 8 Sep 2008 13:11:24 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:52389 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753091AbYIHRLX (ORCPT ); Mon, 8 Sep 2008 13:11:23 -0400 Date: Mon, 8 Sep 2008 13:11:19 -0400 From: Christoph Hellwig To: Takashi Sato Cc: Andrew Morton , Christoph Hellwig , Oleg Nesterov , "linux-fsdevel@vger.kernel.org" , "dm-devel@redhat.com" , "viro@ZenIV.linux.org.uk" , "linux-ext4@vger.kernel.org" , "xfs@oss.sgi.com" , "axboe@kernel.dk" , "mtk.manpages@googlemail.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 3/3] Add timeout feature Message-ID: <20080908171119.GB22521@infradead.org> References: <20080908205337t-sato@mail.jp.nec.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080908205337t-sato@mail.jp.nec.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 08, 2008 at 08:53:37PM +0900, Takashi Sato wrote: > The timeout feature is added to "freeze ioctl" to solve a deadlock > when the freezer accesses a frozen filesystem. And new ioctl > to reset the timeout period is added to extend the timeout period. > For example, the freezer resets the timeout period to 10 seconds every 5 > seconds. In this approach, even if the freezer causes a deadlock by > accessing the frozen filesystem, it will be solved by the timeout > in 10 seconds and the freezer will be able to recognize that > at the next reset of timeout period. And as with all previous posting I still fundamentally disagree about the need of this functionality. We don't need a timeout for freezing.