From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755944AbYIIHW2 (ORCPT ); Tue, 9 Sep 2008 03:22:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753783AbYIIHWU (ORCPT ); Tue, 9 Sep 2008 03:22:20 -0400 Received: from server.drzeus.cx ([85.8.24.28]:44182 "EHLO smtp.drzeus.cx" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753531AbYIIHWT (ORCPT ); Tue, 9 Sep 2008 03:22:19 -0400 Date: Tue, 9 Sep 2008 09:22:16 +0200 From: Pierre Ossman To: "Matt Fleming" Cc: linux-kernel@vger.kernel.org, dbrownell@users.sourceforge.net Subject: Re: [RFC][PATCH] MMC: Use write timeout value as read from CSR Message-ID: <20080909092216.46a6eba1@mjolnir.drzeus.cx> In-Reply-To: <5ff4a1e50809080628i65bd7c7blfac70659a9f9229c@mail.gmail.com> References: <5ff4a1e50809010812i32168136qea538ba177b81446@mail.gmail.com> <20080907123832.5ba79c12@mjolnir.drzeus.cx> <5ff4a1e50809080628i65bd7c7blfac70659a9f9229c@mail.gmail.com> X-Mailer: Claws Mail 3.5.0cvs92 (GTK+ 2.14.0; i386-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Sep 2008 14:28:00 +0100 "Matt Fleming" wrote: > 2008/9/7 Pierre Ossman : > > > > This actually isn't fully correct for SD either as it only specifies > > that 250 ms is the upper bound on the timeout. > > > > I believe the proper way of solving this is to have mmc_spi respect the > > timeouts set in the request structure. Modify mmc_set_data_timeout() if > > necessary. > > > > You're right, I changed the patch accordingly (I also fixed the read > timeout path). > This still doesn't use the fields from the request structure. E.g. SDIO support is probably still broken here as it mandates a timeout of 1 second for data transfers. -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.