From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755983AbYIIOhm (ORCPT ); Tue, 9 Sep 2008 10:37:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753787AbYIIOhe (ORCPT ); Tue, 9 Sep 2008 10:37:34 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:41159 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753390AbYIIOhe (ORCPT ); Tue, 9 Sep 2008 10:37:34 -0400 Date: Tue, 9 Sep 2008 16:37:24 +0200 From: Ingo Molnar To: Prarit Bhargava Cc: linux-kernel@vger.kernel.org, dzickus@redhat.com, nhorman@redhat.com, vgoyal@redhat.com Subject: Re: [PATCH] Fix memmap=exactmap boot argument Message-ID: <20080909143724.GA16026@elte.hu> References: <20080909134858.20868.51265.sendpatchset@prarit.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080909134858.20868.51265.sendpatchset@prarit.bos.redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Prarit Bhargava wrote: > When using kdump modifying the e820 map is yielding strange results. [...] > > This is happening because of an improper usage of strcmp() in the > e820 parsing code. The strcmp() always returns !0 and never resets the > value for e820.nr_map and returns an incorrect user-defined map. > > This patch fixes the problem. > > Signed-off-by: Prarit Bhargava applied to tip/x86/urgent, thanks Prarit! Ingo