From: Pete Zaitcev <zaitcev@redhat.com>
To: <jdmason@kudzu.us>, <muli@il.ibm.com>
Cc: zaitcev@redhat.com, linux-kernel@vger.kernel.org
Subject: Calgary and bad_dma_address
Date: Tue, 9 Sep 2008 21:19:41 -0600 [thread overview]
Message-ID: <20080909211941.0a0fda6a.zaitcev@redhat.com> (raw)
Hi, guys:
I was reading arch/x86/kernel/pci-calgary_64.c today, and noticed that
apparently nothing prevents iommu_area_alloc from returning a zero.
But bad_dma_address is zero too. Doesn't it concern anyone?
If the first allocation asks for a page-aligned buffer to be mapped,
a spurious bad address will result, if I understand this right.
The simplest way to avoid the problem is to lose a page and set a bit
in tce_table_setparms():
set_bit(tbl->it_map, bad_dma_address);
But I don't see anything like that done anywhere.
-- Pete
next reply other threads:[~2008-09-10 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 3:19 Pete Zaitcev [this message]
2008-09-10 3:37 ` David Miller
2008-09-10 3:57 ` Pete Zaitcev
2008-09-10 3:38 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080909211941.0a0fda6a.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®