From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753600AbYIJIB3 (ORCPT ); Wed, 10 Sep 2008 04:01:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751288AbYIJIBW (ORCPT ); Wed, 10 Sep 2008 04:01:22 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:38122 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbYIJIBV (ORCPT ); Wed, 10 Sep 2008 04:01:21 -0400 Date: Wed, 10 Sep 2008 10:00:55 +0200 From: Ingo Molnar To: Jeremy Fitzhardinge Cc: Hugh Dickins , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH tip] x86: unsigned long pte_pfn Message-ID: <20080910080055.GB15255@elte.hu> References: <48C589D2.5030905@goop.org> <48C6A9C2.7000401@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48C6A9C2.7000401@goop.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jeremy Fitzhardinge wrote: > > [PATCH tip] x86: unsigned long pte_pfn > > > > pte_pfn() has always been of type unsigned long, even on 32-bit PAE; > > but in the current tip/next/mm tree it works out to be unsigned long > > long on 64-bit, which gives an irritating warning if you try to printk > > a pfn with the usual %lx. > > > > Now use the same pte_pfn() function, moved from pgtable-3level.h > > to pgtable.h, for all models: as suggested by Jeremy Fitzhardinge. > > And pte_page() can well move along with it (remaining a macro to > > avoid dependence on mm_types.h). > > > > Signed-off-by: Hugh Dickins > > > Acked-by: Jeremy Fitzhardinge applied to tip/x86/mm, thanks guys! Ingo