From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755650AbYIJUQh (ORCPT ); Wed, 10 Sep 2008 16:16:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753525AbYIJUQG (ORCPT ); Wed, 10 Sep 2008 16:16:06 -0400 Received: from wilson.telenet-ops.be ([195.130.132.42]:36248 "EHLO wilson.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752248AbYIJUQE (ORCPT ); Wed, 10 Sep 2008 16:16:04 -0400 Message-Id: <20080910201530.880263695@mail.of.borg> References: <20080910201517.233690597@mail.of.borg> User-Agent: quilt/0.46-1 Date: Wed, 10 Sep 2008 22:15:18 +0200 From: Geert Uytterhoeven To: Linus Torvalds , Magnus Damm , Mauro Carvalho Chehab Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mundt , video4linux-list@redhat.com, Magnus Damm Subject: [patch 1/2] VIDEO_SH_MOBILE_CEU should depend on HAS_DMA Content-Disposition: inline; filename=VIDEO_SH_MOBILE_CEU-needs-DMA.diff Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geert Uytterhoeven commit 0d3244d6439c8c31d2a29efd587c7aca9042c8aa ("V4L/DVB (8342): sh_mobile_ceu_camera: Add SuperH Mobile CEU driver V3") introduced VIDEO_SH_MOBILE_CEU, which selects VIDEOBUF_DMA_CONTIG. This circumvents the dependency on HAS_DMA of VIDEOBUF_DMA_CONTIG. Add a dependency on HAS_DMA to VIDEO_SH_MOBILE_CEU to fix this. Signed-off-by: Geert Uytterhoeven Acked-by: Paul Mundt Acked-by: Magnus Damm --- This broke m68k allmodconfig (which still selects Sun-3). I assume it also affects the other NO_DMA platforms like h8300, m32r, s390, and PCI-less SPARC? drivers/media/video/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/video/Kconfig +++ b/drivers/media/video/Kconfig @@ -968,7 +968,7 @@ config VIDEO_PXA27x config VIDEO_SH_MOBILE_CEU tristate "SuperH Mobile CEU Interface driver" - depends on VIDEO_DEV + depends on VIDEO_DEV && HAS_DMA select SOC_CAMERA select VIDEOBUF_DMA_CONTIG ---help--- -- Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds