From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754896AbYIKLPk (ORCPT ); Thu, 11 Sep 2008 07:15:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752406AbYIKLPc (ORCPT ); Thu, 11 Sep 2008 07:15:32 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:56213 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752230AbYIKLPb (ORCPT ); Thu, 11 Sep 2008 07:15:31 -0400 Date: Thu, 11 Sep 2008 20:20:02 +0900 From: KAMEZAWA Hiroyuki To: KAMEZAWA Hiroyuki Cc: balbir@linux.vnet.ibm.com, "xemul@openvz.org" , "hugh@veritas.com" , linux-mm@kvack.org, linux-kernel@vger.kernel.org, menage@google.com Subject: [RFC] [PATCH 7/9] memcg: charge likely success Message-Id: <20080911202002.d644bc59.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20080911200855.94d33d3b.kamezawa.hiroyu@jp.fujitsu.com> References: <20080911200855.94d33d3b.kamezawa.hiroyu@jp.fujitsu.com> Organization: Fujitsu X-Mailer: Sylpheed 2.4.2 (GTK+ 2.10.11; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In fast path, res_counter_charge() will success. This annotation 'unlikely' works very well to make footprint shorter. (And you can see the benefit of this by some benchmarks.) Signed-off-by: KAMEZAWA Hiroyuki Index: mmtom-2.6.27-rc5+/mm/memcontrol.c =================================================================== --- mmtom-2.6.27-rc5+.orig/mm/memcontrol.c +++ mmtom-2.6.27-rc5+/mm/memcontrol.c @@ -683,7 +683,7 @@ static int mem_cgroup_charge_common(stru css_get(&memcg->css); } - while (res_counter_charge(&mem->res, PAGE_SIZE)) { + while (unlikely(res_counter_charge(&mem->res, PAGE_SIZE))) { if (!(gfp_mask & __GFP_WAIT)) goto out;