From: Lennert Buytenhek <buytenh@wantstofly.org>
To: Zev Weiss <zevweiss@gmail.com>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] [MTD] physmap.c: Add #endif comments
Date: Sat, 13 Sep 2008 12:46:41 +0200 [thread overview]
Message-ID: <20080913104641.GE21603@xi.wantstofly.org> (raw)
In-Reply-To: <48CB5E9F.9060109@gmail.com>
On Fri, Sep 12, 2008 at 11:33:03PM -0700, Zev Weiss wrote:
> Adding comments to a few of the less painfully-obvious #endifs.
>
> Signed-off-by: Zev Weiss <zevweiss@gmail.com>
> ---
> drivers/mtd/maps/physmap.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
> index 6fba0d4..49e2039 100644
> --- a/drivers/mtd/maps/physmap.c
> +++ b/drivers/mtd/maps/physmap.c
> @@ -244,7 +244,7 @@ static void physmap_flash_shutdown(struct platform_device *dev)
> #define physmap_flash_suspend NULL
> #define physmap_flash_resume NULL
> #define physmap_flash_shutdown NULL
> -#endif
> +#endif /* CONFIG_PM */
>
> static struct platform_driver physmap_flash_driver = {
> .probe = physmap_flash_probe,
> @@ -302,8 +302,8 @@ void physmap_set_partitions(struct mtd_partition *parts, int
> num_parts)
> physmap_flash_data.nr_parts = num_parts;
> physmap_flash_data.parts = parts;
> }
> -#endif
> -#endif
> +#endif /* CONFIG_MTD_PARTITIONS */
> +#endif /* PHYSMAP_COMPAT */
I thought that this was frowned upon. (I don't like it myself, and
my editor is perfectly well capable of pointing out to me which ifdef
matches up with which endif.)
next prev parent reply other threads:[~2008-09-13 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 6:33 Zev Weiss
2008-09-13 10:46 ` Lennert Buytenhek [this message]
2008-09-13 11:26 ` Zev Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080913104641.GE21603@xi.wantstofly.org \
--to=buytenh@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=zevweiss@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®