From: Pete Zaitcev <zaitcev@redhat.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usbmon: fix tiny race exposed by the fastboot patches
Date: Sat, 13 Sep 2008 14:05:07 -0600 [thread overview]
Message-ID: <20080913140507.91f8b0fe.zaitcev@redhat.com> (raw)
In-Reply-To: <20080913124858.529fb8e2@infradead.org>
On Sat, 13 Sep 2008 12:48:58 -0700, Arjan van de Ven <arjan@infradead.org> wrote:
> +++ b/drivers/usb/mon/mon_main.c
> @@ -361,12 +361,12 @@ static int __init mon_init(void)
> }
> // MOD_INC_USE_COUNT(which_module?);
>
> - usb_register_notify(&mon_nb);
>
> mutex_lock(&usb_bus_list_lock);
> list_for_each_entry (ubus, &usb_bus_list, bus_list) {
> mon_bus_init(ubus);
> }
> + usb_register_notify(&mon_nb);
> mutex_unlock(&usb_bus_list_lock);
Looks like the above does not add new deadlocks and does not
miss notifications, so ACK.
-- Pete
prev parent reply other threads:[~2008-09-13 20:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-13 19:48 Arjan van de Ven
2008-09-13 20:05 ` Pete Zaitcev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080913140507.91f8b0fe.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome