From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754632AbYIOGli (ORCPT ); Mon, 15 Sep 2008 02:41:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751777AbYIOGl3 (ORCPT ); Mon, 15 Sep 2008 02:41:29 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40908 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbYIOGl2 (ORCPT ); Mon, 15 Sep 2008 02:41:28 -0400 Date: Mon, 15 Sep 2008 08:41:06 +0200 From: Ingo Molnar To: Roland McGrath Cc: Frank Mayhar , linux-kernel , Thomas Gleixner , Alexey Dobriyan , Andrew Morton Subject: Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang. Message-ID: <20080915064106.GB15680@elte.hu> References: <1221238479.30136.2.camel@bobble.smo.corp.google.com> <20080914151404.GA28850@elte.hu> <20080914193140.728F56409D@pipsqueak.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080914193140.728F56409D@pipsqueak.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0001] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Roland McGrath wrote: > > please uninline these functions. > > They are short and have only one caller. then they should be defined in the .c file which uses them. really, sched.h is large enough already and has lots of unnecessary stuff in it. Ingo