mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [RFC][PATCH] x86: add memory clobber in switch_to()
Date: Mon, 15 Sep 2008 09:54:34 +0200	[thread overview]
Message-ID: <20080915075434.GB29585@elte.hu> (raw)
In-Reply-To: <20080914170353.GA15729@damson.getinternet.no>


* Vegard Nossum <vegard.nossum@gmail.com> wrote:

> There are more places which have segment register reloads without 
> adding memory clobbers. Should we fix them up? Here's one of them:

yes, i think so.

> >From 5f135687f7730fbdd979b6fb408fd3ca08a0a678 Mon Sep 17 00:00:00 2001
> From: Vegard Nossum <vegard.nossum@gmail.com>
> Date: Sun, 14 Sep 2008 18:53:22 +0200
> Subject: [PATCH] x86: add memory clobber in switch_to()
> 
> Segment registers are reloaded, so we should add a memory clobber. The 
> generated assembly code is identical in my tests, but this doesn't 
> mean it is necessarily true for all configurations/compilers.

applied to tip/x86/core, thanks Vegard.

	Ingo

      reply	other threads:[~2008-09-15  7:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-14 17:03 Vegard Nossum
2008-09-15  7:54 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080915075434.GB29585@elte.hu \
    --to=mingo@elte.hu \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vegard.nossum@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®