From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754139AbYIOOMU (ORCPT ); Mon, 15 Sep 2008 10:12:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752915AbYIOOME (ORCPT ); Mon, 15 Sep 2008 10:12:04 -0400 Received: from smtp5.pp.htv.fi ([213.243.153.39]:48264 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752634AbYIOOMD (ORCPT ); Mon, 15 Sep 2008 10:12:03 -0400 Date: Mon, 15 Sep 2008 17:11:49 +0300 From: Adrian Bunk To: Randy Dunlap , Hannes Reinecke , Kay Sievers , Greg Kroah-Hartman Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , netdev Subject: Re: linux-next: Tree for September 13 (3c509) Message-ID: <20080915141149.GA10002@cs181140183.pp.htv.fi> References: <20080913162344.ab395285.sfr@canb.auug.org.au> <20080914141757.899f71eb.randy.dunlap@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080914141757.899f71eb.randy.dunlap@oracle.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 14, 2008 at 02:17:57PM -0700, Randy Dunlap wrote: > drivers/net/3c509.c fails (CONFIG_PM=y) with: > > drivers/built-in.o:(.data+0x7dcc): undefined reference to `el3_resume' > drivers/built-in.o:(.data+0x7e08): undefined reference to `el3_resume' > > It seems that this function does not exist in the source file. It got removed by: commit 107aeb9753159da848f066b26557f0aaab900a90 Author: Hannes Reinecke Date: Wed Sep 10 14:16:04 2008 +0200 Driver core: Use dev_get_drvdata() accessors Deprecated direct access to the ->driver_data field and use accessors throughout. Signed-off-by: Hannes Reinecke Cc: Kay Sievers Signed-off-by: Greg Kroah-Hartman cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed