From: Ingo Molnar <mingo@elte.hu>
To: Frank Mayhar <fmayhar@google.com>
Cc: Roland McGrath <roland@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang.
Date: Tue, 16 Sep 2008 10:39:15 +0200 [thread overview]
Message-ID: <20080916083915.GB17287@elte.hu> (raw)
In-Reply-To: <1221501582.19012.30.camel@bobble.smo.corp.google.com>
* Frank Mayhar <fmayhar@google.com> wrote:
> On Mon, 2008-09-15 at 08:41 +0200, Ingo Molnar wrote:
> > * Roland McGrath <roland@redhat.com> wrote:
> >
> > > > please uninline these functions.
> > >
> > > They are short and have only one caller.
> >
> > then they should be defined in the .c file which uses them.
>
> Well, they are actually used in sched.h, in the inline routines
> account_group_user_time() and friends, which are in turn used by
> routines in sched.c. The point here is that the
> thread_group_cputime_account_xxx() routines are defined differently
> depending upon whether we're building for UP or SMP and the
> account_group_xxx() routines use the appropriate version accordingly.
>
> > really, sched.h is large enough already and has lots of unnecessary
> > stuff in it.
>
> Agreed, but Roland and I were trying to make life easier for folks who
> have to maintain SMP and UP versions of this stuff, keeping it all in
> one place rather than scattering it about.
>
> If you insist, I'll un-inline the routines but this will mean moving
> all of this (thread_group_cputime_account_xxx() and
> account_group_xxx() routines) to sched.c. Maybe that makes sense.
> It's your call; I'll hold off on the changes (and resubmitting the
> patch) while I wait for you to let me know what you prefer. Thanks.
it's already in tip/sched/posix-cpu-timers, so please send a delta patch
against tip/master:
http://people.redhat.com/mingo/tip.git/README
i'd suggest to move all the scheduler-internal accounting functions into
kernel/sched_stats.h. AFAICS there's no scheduler-external user of these
APIs. The most widely used external APIs is thread_group_cputime_smp(),
and that is out of line already. (except on UP where it's trivial)
Ingo
prev parent reply other threads:[~2008-09-16 8:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 16:54 Frank Mayhar
2008-09-12 20:27 ` Andrew Morton
2008-09-14 15:06 ` Ingo Molnar
2008-09-14 15:07 ` [PATCH] timers: fix itimer/many thread hang, fix Ingo Molnar
2008-09-14 15:09 ` [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang Ingo Molnar
2008-09-15 18:09 ` Frank Mayhar
2008-09-16 8:41 ` Ingo Molnar
2008-09-17 19:03 ` Frank Mayhar
2008-09-17 19:13 ` Roland McGrath
2008-09-17 20:12 ` Frank Mayhar
2008-09-18 10:23 ` Ingo Molnar
2008-09-18 13:50 ` Frank Mayhar
2008-09-22 20:22 ` [PATCH 2.6.27-rc5 re-resubmit] " Frank Mayhar
2008-09-23 11:40 ` Ingo Molnar
2008-09-23 12:52 ` [boot crash] " Ingo Molnar
2008-09-23 13:59 ` Oleg Nesterov
2008-09-23 16:09 ` Frank Mayhar
2008-09-23 22:56 ` Frank Mayhar
2008-09-24 21:23 ` [PATCH 2.6.27-rc5 incremental " Frank Mayhar
2008-09-27 18:08 ` Ingo Molnar
2008-09-30 6:33 ` Ingo Molnar
2008-09-30 16:36 ` Frank Mayhar
2008-10-01 16:20 ` Frank Mayhar
2008-10-02 9:43 ` Ingo Molnar
2008-09-14 15:12 ` [PATCH 2.6.27-rc5 resubmit] " Ingo Molnar
2008-09-14 15:14 ` Ingo Molnar
2008-09-14 19:31 ` Roland McGrath
2008-09-15 6:41 ` Ingo Molnar
2008-09-15 17:59 ` Frank Mayhar
2008-09-16 8:39 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916083915.GB17287@elte.hu \
--to=mingo@elte.hu \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®