From: Oleg Nesterov <oleg@tv-sign.ru>
To: Frank Mayhar <fmayhar@google.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
adobriyan@gmail.com, mingo@elte.hu, roland@redhat.com,
tglx@linutronix.de
Subject: Re: + itimers-fix-itimer-many-thread-hang.patch added to -mm tree
Date: Tue, 16 Sep 2008 15:13:03 +0400 [thread overview]
Message-ID: <20080916111303.GA176@tv-sign.ru> (raw)
In-Reply-To: <1221500983.19012.21.camel@bobble.smo.corp.google.com>
On 09/15, Frank Mayhar wrote:
>
> I have a few more things to do; expect a new iteration of the patch
> tonight or tomorrow.
Great.
Please also remove tasklist_lock from thread_group_cputime_alloc_smp(),
it is not needed.
I'd also suggest to kill
if (sig->cputime.totals)
return 0;
, the caller has already checked this.
Please note also that thread_group_cputime_clone_thread() doesn't need
the second argument.
Very minor nit, but thread_group_cputime_alloc_smp() doesn't really
need get_cpu() + put_cpu_no_resched(), it can use smp_processor_id().
Oleg.
next prev parent reply other threads:[~2008-09-16 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200809122353.m8CNrCmR011310@imap1.linux-foundation.org>
2008-09-14 17:50 ` Oleg Nesterov
2008-09-14 18:39 ` Ingo Molnar
2008-09-15 12:34 ` Oleg Nesterov
2008-09-15 12:56 ` Ingo Molnar
2008-09-15 17:49 ` Frank Mayhar
2008-09-16 11:13 ` Oleg Nesterov [this message]
2008-09-17 8:21 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080916111303.GA176@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=fmayhar@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=roland@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®