From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Michael Trimarchi <trimarchimichael@yahoo.it>
Cc: Hisashi Hifumi <hifumi.hisashi@oss.ntt.co.jp>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] VFS: make file->f_pos access atomic on 32bit arch
Date: Tue, 16 Sep 2008 22:54:21 +1000 [thread overview]
Message-ID: <200809162254.21514.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <58603.86657.qm@web26202.mail.ukl.yahoo.com>
On Tuesday 16 September 2008 21:11, Michael Trimarchi wrote:
> Hi,
>
> > + if (offset != file_pos_read(file))
> > + file_pos_write(file, offset);
> > retval = offset;
> > }
>
> Is not more efficient here a compare xchg operation?
The compiler should do it if it was.
next prev parent reply other threads:[~2008-09-16 12:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 11:11 Michael Trimarchi
2008-09-16 12:54 ` Nick Piggin [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-09-16 16:01 Michael Trimarchi
[not found] <bcGib-3Fp-7@gated-at.bofh.it>
2008-09-16 15:32 ` Bodo Eggert
2008-09-16 14:57 Michael Trimarchi
2008-09-17 1:24 ` Nick Piggin
2008-09-18 9:59 ` Hisashi Hifumi
2008-09-18 7:08 ` Hisashi Hifumi
2008-09-16 13:57 Michael Trimarchi
2008-09-16 14:11 ` Nick Piggin
2008-09-16 10:35 Hisashi Hifumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809162254.21514.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=akpm@linux-foundation.org \
--cc=hifumi.hisashi@oss.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trimarchimichael@yahoo.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®