From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbYIQIwu (ORCPT ); Wed, 17 Sep 2008 04:52:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751292AbYIQIwm (ORCPT ); Wed, 17 Sep 2008 04:52:42 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:40779 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751025AbYIQIwl (ORCPT ); Wed, 17 Sep 2008 04:52:41 -0400 Date: Wed, 17 Sep 2008 10:52:27 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Thomas Gleixner , "H. Peter Anvin" , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/6] x86: add KERN_APIC Message-ID: <20080917085227.GB27317@elte.hu> References: <1221640067-24389-1-git-send-email-yhlu.kernel@gmail.com> <1221640067-24389-7-git-send-email-yhlu.kernel@gmail.com> <20080917083809.GB24035@elte.hu> <86802c440809170145s317e6ef8xad352e3a306abe45@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86802c440809170145s317e6ef8xad352e3a306abe45@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > On Wed, Sep 17, 2008 at 1:38 AM, Ingo Molnar wrote: > > > > * Yinghai Lu wrote: > > > >> and kill apic_printk > >> using loglevel=apic:8 instead > > > > yes, that aspect is very nice. > > > >> +DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6); > > > >> - printk(KERN_WARNING "APIC calibration not consistent " > >> + printk(KERN_WARNING KERN_APIC "APIC calibration not consistent " > > > > here too the question arises: what should the semantics of the 'mixing' > > of such subsystem printk tags with the classic priority tags be. I think > > in this particular case we dont want the KERN_APIC tag, as that would > > prevent this failure message to be printed by default. I.e. this line > > should remain: > > > >> - printk(KERN_WARNING "APIC calibration not consistent " > > > > to make sure this warning always shows up in the logs. Agreed? > > with > > DEFINE_LOGLEVEL_SETUP_DEF(apic, KERN_APIC, "apic:", 6); > > the KERN_WARNING <5> will be showing up that warning, even without > loglevl=apic:8 ok, but if that printk will show up no matter what, why is there any need to add an extra tag? my main worry is the duplication of the tag. People have a hard enough time adding a _single_ printk tag - adding multiple ones is clearly too much. Ingo