From: WANG Cong <xiyou.wangcong@gmail.com>
To: Alberto Bertogli <albertito@blitiri.com.ar>
Cc: jdike@addtoit.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] uml: Make vde_user.c build again
Date: Wed, 17 Sep 2008 12:49:38 +0100 [thread overview]
Message-ID: <20080917114938.GB2898@hack.voiplan.pt> (raw)
In-Reply-To: <1221612200-483-1-git-send-email-albertito@blitiri.com.ar>
On Tue, Sep 16, 2008 at 09:43:19PM -0300, Alberto Bertogli wrote:
>Commit 43f5b308 ("uml: fix build when SLOB is enabled") removed kmalloc()
>from um_malloc.h, which breaks vde_user.c.
>
>This patch fixes it by making vde_user.c call uml_kmalloc() instead of
>kmalloc().
>
>Signed-off-by: Alberto Bertogli <albertito@blitiri.com.ar>
>---
>
>This patch is against the Linus' current (as of about 5 minutes ago) tree.
>Without this patch, it wouldn't build.
>
>I've tested it by booting my uml image, connecting it to the internet using
>vde_witch, and doing some network operations (some aptitude installs).
>
>Thanks a lot,
> Alberto
>
>
> arch/um/drivers/vde_user.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/arch/um/drivers/vde_user.c b/arch/um/drivers/vde_user.c
>index 56533db..744eacf 100644
>--- a/arch/um/drivers/vde_user.c
>+++ b/arch/um/drivers/vde_user.c
>@@ -78,7 +78,7 @@ void vde_init_libstuff(struct vde_data *vpri, struct vde_init *init)
> {
> struct vde_open_args *args;
>
>- vpri->args = kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
>+ vpri->args = uml_kmalloc(sizeof(struct vde_open_args), UM_GFP_KERNEL);
> if (vpri->args == NULL) {
> printk(UM_KERN_ERR "vde_init_libstuff - vde_open_args "
> "allocation failed");
http://lkml.org/lkml/2008/7/23/142
--
"Sometimes the only way to stay sane is to go a little crazy."
next prev parent reply other threads:[~2008-09-17 11:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-17 0:43 Alberto Bertogli
2008-09-17 11:49 ` WANG Cong [this message]
2008-09-19 22:50 ` Alberto Bertogli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917114938.GB2898@hack.voiplan.pt \
--to=xiyou.wangcong@gmail.com \
--cc=albertito@blitiri.com.ar \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®