From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755304AbYIQTUw (ORCPT ); Wed, 17 Sep 2008 15:20:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752821AbYIQTUm (ORCPT ); Wed, 17 Sep 2008 15:20:42 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:54832 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752319AbYIQTUl (ORCPT ); Wed, 17 Sep 2008 15:20:41 -0400 Date: Wed, 17 Sep 2008 12:19:43 -0700 From: Andrew Morton To: "Theodore Ts'o" Cc: linux-kernel@vger.kernel.org, tytso@MIT.EDU, eugene@ibrix.com, msnitzer@ibrix.com, linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/4] ext3: Fix ext3_dx_readdir hash collision handling Message-Id: <20080917121943.904b66b6.akpm@linux-foundation.org> In-Reply-To: <1221319971-29879-1-git-send-email-tytso@mit.edu> References: <1221319971-29879-1-git-send-email-tytso@mit.edu> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 13 Sep 2008 11:32:48 -0400 "Theodore Ts'o" wrote: > This fixes a bug where readdir() would return a directory entry twice > if there was a hash collision in an hash tree indexed directory. That sounds like a serious problem, but given the amount of time it took to turn up, I guess it's pretty rare. What are your thoughts regarding a 2.6.27 merge for this? 2.6.26.x? 2.6.25.x? ...