From: David Miller <davem@davemloft.net>
To: benli@broadcom.com
Cc: riel@redhat.com, mchan@broadcom.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bnx2: Promote vector field in bnx2_irq structure from u16 to unsigned int
Date: Thu, 18 Sep 2008 16:46:27 -0700 (PDT) [thread overview]
Message-ID: <20080918.164627.94070091.davem@davemloft.net> (raw)
In-Reply-To: <1221667442-4495-2-git-send-email-benli@broadcom.com>
From: "Benjamin Li" <benli@broadcom.com>
Date: Wed, 17 Sep 2008 09:04:02 -0700
> The bnx2 driver stores/uses the irq value from the pci_dev internally.
> But when it stores the irq value, it has been performing an
> integer demotion. Because of the recent changes made to
> arch/x86/kernel/io_apic.c, the new method in creating the irq value
> (using build_irq_for_pci_dev()) has exposed this bug on x86 systems.
>
> Because of this demotion when calling request_irq() from
> bnx2_request_irq(), the driver would get a return code of -EINVAL.
> This is because the kernel could not find the requested irq descriptor.
> By storing the irq value properly, the kernel can find the correct
> irq descriptor and the bnx2 driver can operate normally.
>
> Signed-off-by: Benjamin Li <benli@broadcom.com>
> Signed-off-by: Michael Chan <mchan@broadcom.com>
Applied to net-2.6, thanks!
next prev parent reply other threads:[~2008-09-18 23:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 5:40 2.6.27-rc5-mm1 Andrew Morton
2008-09-05 7:20 ` 2.6.27-rc5-mm1 Takashi Iwai
2008-09-05 7:50 ` 2.6.27-rc5-mm1 Alexander Beregalov
2008-09-05 8:25 ` 2.6.27-rc5-mm1 Andrew Morton
2008-09-05 12:39 ` 2.6.27-rc5-mm1: rmmod ide-cd_mod: tried to init an initialized object, something is seriously wrong Mariusz Kozlowski
2008-09-05 13:28 ` Rafael J. Wysocki
2008-09-05 13:44 ` Mariusz Kozlowski
2008-09-05 16:25 ` Mariusz Kozlowski
2008-09-06 12:35 ` FUJITA Tomonori
2008-09-08 8:43 ` Jens Axboe
2008-09-08 9:27 ` Jens Axboe
2008-09-09 9:07 ` Mariusz Kozlowski
2008-09-09 10:29 ` Jens Axboe
2008-09-09 12:14 ` Mariusz Kozlowski
2008-09-09 13:21 ` Jens Axboe
2008-09-05 17:26 ` 2.6.27-rc5-mm1: list corruption during blk_add_timer() Alexey Dobriyan
2008-09-05 19:40 ` Andrew Morton
2008-09-08 9:30 ` Jens Axboe
2008-09-05 19:32 ` [PATCH -mm] Fix dev_load() compilation again Alexey Dobriyan
2008-09-05 19:54 ` Hiroshi Shimamoto
2008-09-07 4:08 ` Stephen Rothwell
2008-09-08 22:17 ` Andrew Morton
2008-09-09 6:27 ` Johannes Berg
2008-09-09 11:07 ` 2.6.27-rc5-mm1 Dmitri Vorobiev
2008-09-11 10:16 ` 2.6.27-rc5-mm1 Dmitri Vorobiev
2008-09-11 14:59 ` 2.6.27-rc5-mm1 Kevin D. Kissell
2008-09-15 22:01 ` 2.6.27-rc5-mm1 Rik van Riel
2008-09-15 23:00 ` 2.6.27-rc5-mm1 Michael Chan
2008-09-16 18:09 ` 2.6.27-rc5-mm1 Rik van Riel
2008-09-16 23:01 ` 2.6.27-rc5-mm1 Rik van Riel
2008-09-17 19:23 ` 2.6.27-rc5-mm1 Benjamin Li
[not found] ` <1221667442-4495-1-git-send-email-benli@broadcom.com>
[not found] ` <1221667442-4495-2-git-send-email-benli@broadcom.com>
2008-09-18 23:46 ` David Miller [this message]
2008-09-17 18:52 [PATCH] bnx2: Promote vector field in bnx2_irq structure from u16 to unsigned int Benjamin Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918.164627.94070091.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=benli@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome